Two issues found while verifying the live install:
1. pack.py produced a different zip MD5 for identical content, because zip
records file mtimes. Re-running pack.py would have rewritten the manifest
checksum while the already-published asset stayed the same, and Jellyfin
would then refuse the install with "The checksum of the received data
doesn't match." The zip entry now carries a fixed 1980-01-01 timestamp, and
--publish downloads the published asset back and compares its MD5 with the
manifest checksum before reporting success.
2. The legacy deploy.py tag lives in the on-disk index.html, so it was stripped
from every single response and logged at INFO each time (6 lines and counting
per boot on the live server). The message is now emitted once, and says what
it actually means: the tag is still on disk, run deploy.py rollback to clean
it up.
Verified: 21/21 rewrite checks pass, including a regression case built from the
tag actually present on the server.
Replaces the deploy.py approach (which sed-patched index.html inside the
container, and was therefore lost on every jellyfin/jellyfin upgrade) with a
proper plugin installable from a Jellyfin plugin repository.
The web bundle is unchanged: the same src/*.js -> dist/jfvr.js is now embedded
in Jellyfin.Plugin.JFVR.dll and served from /JFVR/jfvr.js with a content-hash
cache key. index.html is rewritten at request time by an IStartupFilter
middleware, so nothing on disk is touched.
Verified before this commit:
- dotnet build: 0 warnings, 0 errors (net10.0, Jellyfin.Controller 12.1.0)
- the DLL embeds dist/jfvr.js byte for byte
- 19/19 checks on the rewrite logic (injection, idempotency, legacy-tag
takeover, no </body> safety, other scripts preserved, URL override)
- manifest.json passes Jellyfin's PackageInfo/VersionInfo expectations
- the packaged zip's MD5 matches the checksum the manifest advertises
Details that were checked against the Jellyfin source rather than assumed:
- a catalog version survives when targetAbi <= serverVersion, so a single
targetAbi 12.0.0.0 package covers all of 12.x (server is 12.1.0)
- Jellyfin writes meta.json itself at install time, so the zip needs only
the DLL
- Jellyfin verifies the MD5 at install time
Also adds pack.py (build -> package -> manifest -> Gitea release) and documents
the plugin route in README/HANDOFF, keeping deploy.py as a fallback.