Commit Graph
2 Commits
Author SHA1 Message Date
Oyster Lee b4416909f5 fix: emit a tool call that arrives with no arguments
A tool call whose arguments never arrive — a no-argument tool, or a model that
sends id and name and then stops — was accumulated into toolCallsState but
never added to the message, because the content block was only created inside
`if (tc.function?.arguments)`.

The finalizer then checked `toolCallsState.length > 0` and set
stopReason "toolUse" on a message containing no tool call at all. pi's agent
loop continues only on tool calls, so it had nothing to execute and the turn
ended: mid-task, no tool run, no error, nothing in the transcript except the
assistant saying what it was about to do. Observed against a real session where
the model announced "let me consult the advisor" four times in a row and the
run then stopped dead; its final message on disk is stopReason "toolUse" with a
single text block and no toolCall.

Two changes:

  - open the block as soon as the call is identifiable (id or name), and keep
    its id/name in step if they arrive in a later delta, since the finalizer
    only rewrites `arguments`;
  - guard the stopReason on blocks that actually reached the message rather
    than on the state array being non-empty, so a genuinely malformed stream
    reports "stop" instead of an unactionable "toolUse".

Tests: no-argument call, identity arriving after the block is open, and a
malformed delta that must not claim toolUse.
2026-08-03 06:50:04 +08:00
Oyster Lee a9a3521b9b fix: forward images returned by tool calls to the model
A tool result can carry images. pi's `read` tool returns a text note plus an
`image` block for png/jpg/gif/webp/bmp, and screenshot tools do the same.

transformMessagesForQoder() built the `tool` message with getContentText(),
which maps every non-text block to "". The images were dropped silently: the
TUI rendered the picture, the model received only "Read image file [image/png]"
and answered that it could not see images — then fell back to scraping the DOM.
Nothing reported a problem, and the model catalogue advertises input
["text", "image"], so the capability check upstream of this had no reason to
warn either.

The OpenAI-shaped `tool` role has nowhere to put them: its content is a plain
string. So the images now follow as a separate user message, using the same
image_url part the user branch already builds, with a short label so the model
does not read a bare image as something the human just sent.

Tool results without images are unchanged and still produce exactly one
message.
2026-08-03 06:20:10 +08:00